Skip to content

[HUDI-2276] Enable metadata table by default for readers and writers #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umehrot2 wants to merge 2 commits into from
Closed

[HUDI-2276] Enable metadata table by default for readers and writers #3411

umehrot2 wants to merge 2 commits into from

Conversation

@umehrot2
Copy link
Contributor

@umehrot2 umehrot2 commented Aug 5, 2021 •
edited
Loading

Tips

What is the purpose of the pull request

We have had metadata table disabled by default in Hudi 0.8.0, as we released it as an experimental feature. With Hudi 0.9.0, we should enable it by default to improve out of the box performance.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@umehrot2 umehrot2 mentioned this pull request Aug 5, 2021
Closed
5 tasks
@hudi-bot
Copy link
Collaborator

hudi-bot commented Aug 5, 2021 •
edited
Loading

CI report:

  • 4c60407f235d421a07efef0831e5618f6fc1de2f UNKNOWN
  • baee9e9 Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@vinothchandar vinothchandar added the priority:blocker Production down; release blocker label Aug 5, 2021
@vinothchandar vinothchandar self-assigned this Aug 5, 2021
@vinothchandar
Copy link
Member

vinothchandar commented Aug 6, 2021

seems like a lot of test failures?

@umehrot2
Copy link
Contributor Author

umehrot2 commented Aug 6, 2021 •
edited
Loading

seems like a lot of test failures?

Yes. Pushed a new revision that fixes some more tests. Lets see. Travis itself isn't running man !

@vinothchandar
Copy link
Member

vinothchandar commented Aug 6, 2021

Look at azure. Travis is beyond redemption

@umehrot2 umehrot2 force-pushed the enable_metadata branch 3 times, most recently from 4c60407 to b90db1e Compare August 11, 2021 21:08
@umehrot2
Copy link
Contributor Author

umehrot2 commented Aug 11, 2021

@prashantwason if you have bandwidth, you can help out with the Integration test failures in the latest run https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=1666&view=logs&j=d5c42908-5572-5ce6-e4a8-5e2053b947e8&t=ff0f581b-ded5-5629-50c0-1f39b9d606b7

[ERROR] Failures: 
[ERROR]   ITTestHoodieDemo.testParquetDemo:111->ingestFirstBatchAndHiveSync:211->ITTestBase.executeCommandStringsInDocker:198->ITTestBase.executeCommandStringInDocker:209->ITTestBase.executeCommandInDocker:188 Command ([spark-submit, --class, org.apache.hudi.hive.HiveSyncTool, /var/hoodie/ws/docker/hoodie/hadoop/hive_base/target/hoodie-hive-sync-bundle.jar, --database, default, --table, stock_ticks_cow, --base-path, /user/hive/warehouse/stock_ticks_cow, --base-file-format, PARQUET, --user, hive, --pass, hive, --jdbc-url, jdbc:hive2://hiveserver:10000, --partitioned-by, dt]) expected to succeed. Exit (1) ==> expected: <0> but was: <1>
[ERROR]   ITTestHoodieSanity.testRunHoodieJavaAppOnMultiPartitionKeysMORTable:107->testRunHoodieJavaApp:207 Expecting 280 rows to be present in the new table ==> expected: <280> but was: <180>
[ERROR]   ITTestHoodieSanity.testRunHoodieJavaAppOnMultiPartitionKeysMORTable:107->testRunHoodieJavaApp:175->ITTestBase.executeCommandStringInDocker:209->ITTestBase.executeCommandInDocker:188 Command ([/var/hoodie/ws/hudi-spark-datasource/hudi-spark/run_hoodie_streaming_app.sh, --hive-sync, --table-path, hdfs://namenode/docker_hoodie_multi_partition_key_mor_test_20210811215021, --hive-url, jdbc:hive2://hiveserver:10000, --table-type, MERGE_ON_READ, --hive-table, docker_hoodie_multi_partition_key_mor_test_20210811215021, --use-multi-partition-keys, --streaming-source-path, hdfs://namenode/streaming/source/docker_hoodie_multi_partition_key_mor_test_20210811215021, --streaming-checkpointing-path, hdfs://namenode/streaming/ckpt/docker_hoodie_multi_partition_key_mor_test_20210811215021]) expected to succeed. Exit (255) ==> expected: <0> but was: <255>
[ERROR]   ITTestHoodieSanity.testRunHoodieJavaAppOnNonPartitionedMORTable:120->testRunHoodieJavaApp:213->testRunHoodieJavaApp:207 Expecting 280 rows to be present in the new table ==> expected: <280> but was: <180>
[ERROR]   ITTestHoodieSanity.testRunHoodieJavaAppOnSinglePartitionKeyMORTable:93->testRunHoodieJavaApp:213->testRunHoodieJavaApp:207 Expecting 280 rows to be present in the new table ==> expected: <280> but was: <180>

@vinothchandar vinothchandar removed the priority:blocker Production down; release blocker label Aug 12, 2021
@nsivabalan
Copy link
Contributor

nsivabalan commented Oct 7, 2021

fixed it along with #3590

@nsivabalan nsivabalan closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinothchandar vinothchandar Awaiting requested review from vinothchandar

@prashantwason prashantwason Awaiting requested review from prashantwason

Assignees

@nsivabalan nsivabalan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@umehrot2 @hudi-bot @vinothchandar @nsivabalan